Skip to content

Improve player view - #336

Open
codingcircus wants to merge 10 commits into
Obsidian-TTRPG-Community:mainfrom
codingcircus:improve-player-view
Open

Improve player view#336
codingcircus wants to merge 10 commits into
Obsidian-TTRPG-Community:mainfrom
codingcircus:improve-player-view

Conversation

@codingcircus

Copy link
Copy Markdown

Pull Request Description

For speedier combat, it would be nice if players could see the AC of the creatures they are fighting. To keep some element of surprise my proposal is to only show the AC after a creature has lost HP already.

Of course I'd put this behind a setting

Changes Proposed

  • New Setting to toggle AC in players view
  • New Column for AC in players view

Related Issues

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

CleanShot 2026-01-04 at 15 43 05@2x CleanShot 2026-01-04 at 15 43 53@2x

Additional Notes

@SondreElg

Copy link
Copy Markdown
Contributor

It's a neat feature, but we might want to give the option of manually toggling the AC display per creature as well.

So the default behaviour is that the GM can toggle the AC display in the player view for individual creatures, and then your solution is a QoL feature that GMs can opt in to use to reduce how much they need to toggle.

Would you be able to add the toggling behaviour, then I'll look at pulling the feature?

@codingcircus

Copy link
Copy Markdown
Author

Thank you for the feedback, I'll take a look. Since the GM is probably more focused on the default encounter view, I'll try to add a toggle there (maybe in the 3 dots menu, something like "Reveal AC")

@codingcircus

codingcircus commented Jan 6, 2026

Copy link
Copy Markdown
Author

I added this option now:
CleanShot 2026-01-06 at 19 26 11@2x

To be honest, I prefer this solution to my initial idea and would probably remove the general option. It's more elegant that way since it leaves more control to the GM and also reveals all creatures of the same type at once, instead of just one. What do you think?

The only thing I'm unsure about is the slightly long wording in the dropdown

@codingcircus

Copy link
Copy Markdown
Author

I improved my implementation now again. I did leave the original setting in their and also added a second setting for the gm to decide if they want to reveal the ac of all creatures of the same type at once.

The only thing I'm still unsure about is the reveal in the dropdown. Do you think it would make more sense in the Edit View of a monster? Or maybe even in both places?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants